If you are talking about selling photos as art, or being hired by a magazine, then yes, that is tough. But as a self-employed commercial photographer, it has Huge potential to make an exceptional salary. Wedding photography alone can keep you busy year round making 100+ per hour or more.
What Sells Best On Shutterstock?
Some types of photos that sell best are Portrait Photography, Food Photography, Landscapes (usually with people) and fine art photography (artsy).